pkp/pkp-lib#11268 Fix retrieval of preprint statistics and improved p… #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasraoni
commented
Apr 12, 2025
jonasraoni
commented
Apr 12, 2025
jonasraoni
force-pushed
the
bugfix-stable-3_4_0-11268-fix-statistics-bug
branch
from
e6ea073 to
8646f3b
Compare
bozana
reviewed
Apr 14, 2025
Contributor
|
Hi @jonasraoni, it all looks good. Maybe just a one small rename? |
1 task
taslangraham
approved these changes
Apr 14, 2025
Contributor
taslangraham
left a comment
taslangraham
left a comment
There was a problem hiding this comment.
Everything looks good, @jonasraoni, aside from the typo Bozana pointed out. I'l approve as the typo is a small thing for you to fix without needing another review round
bozana
approved these changes
Apr 14, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erformance