Position out-of-band graphics inside the reserved box - #8
Merged
Conversation
Raw-format images (kitty/iterm2/sixels) were written at the terminal top-left (\x1b[1;1H) or a fixed cursor-up, forcing the chart to the screen corner and breaking any layout where the chart isn't the only pane. Read the reserved <Box>'s on-screen position from Ink's yoga layout (walking the node tree to sum computed offsets) and place the image there instead, so the chart renders inside its box and can be embedded in a larger TUI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw-format images (kitty/iterm2/sixels) were written at the terminal's top-left (
\x1b[1;1H) or via a fixed cursor-up, which pinned the chart to the screen corner and broke any layout where it isn't the only pane.This reads the reserved
<Box>'s actual on-screen position from Ink's yoga layout (summing computed offsets up the node tree) and places the image there, so the chart renders inside its box and can be embedded in a larger TUI layout.tsc clean; 79 tests pass. (Positioning is runtime-only, so unit tests don't cover the placement itself — verified behavior visually.)