Environment variable credentials above secret file credentials #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like, for example, AWS CLI and v1 of the Python client. Resolves #574
This was referenced Jun 13, 2022
tbarsballe
reviewed
Jun 13, 2022
Contributor
tbarsballe
left a comment
tbarsballe
left a comment
There was a problem hiding this comment.
Looks good to me.
I pulled this branch into the project I was testing SDK v2 with previously, and was able to remove the planet.Auth.from_env("PL_API_KEY").write() without issue, seems to be picking up API key auth as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like, for example, AWS CLI and v1 of the Python client.
Resolves #574