planet data filter CLI command with all options #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreiberkyle
commented
Jun 22, 2022
planet/cli/data.py
Outdated
| return io.str_to_datetime(value) | ||
|
|
||
|
|
||
| class DateRangeFilter(click.Tuple): |
Contributor
Author
There was a problem hiding this comment.
@sgillies I'm extending the click Tuple and ParamType types to implement custom validation, help messages, and conversion for the field-based filters, which are specified by FIELD COMP VALUE, e.g. 'acquired gt 2022-02-02' - curious about your take on this approach.
jreiberkyle
commented
Jun 22, 2022
| download the asset. | ||
|
|
||
|
|
||
| #### Filter |
…cing with custom callbacks
cholmes
approved these changes
Jun 23, 2022
Member
cholmes
left a comment
cholmes
left a comment
There was a problem hiding this comment.
Looks good to me. Excited for this one to land!
sgillies
reviewed
Jun 23, 2022
Contributor
sgillies
left a comment
sgillies
left a comment
There was a problem hiding this comment.
@jreiberkyle the new param types looks like a great approach to me! 🚀 I don't have time to check the rest of the PR.
jreiberkyle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
planet data filtercli command with permission and standard-quality filters as defaults.part of #535