Merged
Conversation
fatih
force-pushed
the
fatih/better-not-found-errors
branch
from
9559078 to
4c2f2e5
Compare
iheanyi
approved these changes
Apr 6, 2021
Contributor
iheanyi
left a comment
iheanyi
left a comment
There was a problem hiding this comment.
This is dope but also LGTM!
This PR improves all generic `Error: Not Found` messages with more detailed and useful messages. Also in every single message we also include the organization, to make sure the user didn't accidentaly executed the CLI command on a different organization. depends on: #147 closes: planetscale/surfaces#163
fatih
force-pushed
the
fatih/better-not-found-errors
branch
from
4c2f2e5 to
f724f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves all generic
Error: Not Foundmessages with more detailed and useful messages. Also in every single message, we also include the organization, to make sure the user didn't accidentally execute the CLI command on a different organization.depends on: #147
closes: planetscale/project-big-bang#163