Fix dangling pointers to intToString() temporaries - #55
Merged
Conversation
`intToString()` returns an `IntString` by value, and several call sites took a pointer to its embedded `strValue` buffer directly off the temporary, whose lifetime ends at the end of the statement. On macOS/clang the dead stack memory is reused before the value is read, so pg_restore got `--jobs ''` and failed; same latent bug in vacuumdb --jobs, a table-exists query param, and sequence setval(). Bind the result to a named local that outlives the pointer.
teknogeek0
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intToString()returns anIntStringby value, and several call sites took a pointer to its embeddedstrValuebuffer directly off the temporary, whose lifetime ends at the end of the statement. On macOS/clang the dead stack memory is reused before the value is read, sopg_restoregot--jobs ''and failed; same latent bug in vacuumdb --jobs, a table-exists query param, and sequencesetval().Bind the result to a named local that outlives the pointer.