Make UpdateThrottlerConfig Enabled optional; add unthrottle and app metrics - #331
Open
maxenglander wants to merge 1 commit into
Open
Make UpdateThrottlerConfig Enabled optional; add unthrottle and app metrics#331maxenglander wants to merge 1 commit into
maxenglander wants to merge 1 commit into
Conversation
…etrics. Matches the api-bb vtctld throttler config surface used by the Inventory2 Staging Runbook. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
VtctldUpdateThrottlerConfigRequest.Enabledwas a plainbool, so JSON always sent enable state. No client fields forunthrottle_apps/app_checked_metrics.Solution:
Enabled *bool, plusUnthrottleAppsandAppCheckedMetricson the request type.Security Impact:
None. Client library only.
Testing:
Made with Cursor