🐛 panic in topology migration - fixed by adding nil check#2
Merged
srm6867 merged 2 commits intov1.9.5-pf9from Apr 16, 2026
Merged
🐛 panic in topology migration - fixed by adding nil check#2srm6867 merged 2 commits intov1.9.5-pf9from
srm6867 merged 2 commits intov1.9.5-pf9from
Conversation
srm6867
changed the title
srm6867
changed the title
srm6867
changed the title
badrinath-pf9
approved these changes
Apr 16, 2026
vaibhavd21
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Why this PR :
When we migrate existing cluster to use topology, the defaulting webhook panics with error -
Error from server: admission webhook "default.cluster.cluster.x-k8s.io" denied the request: panic: runtime error: invalid memory address or nil pointer dereference [recovered]What this PR does :
Added a nil check for
spec.topologyUnit Test: