fix: fix typings of ITCConstructorOptions#4674
Merged
mcollina merged 1 commit intoplatformatic:mainfrom Mar 27, 2026
Merged
Conversation
Signed-off-by: mrazauskas <tom@mrazauskas.de>
mrazauskas
commented
Mar 23, 2026
Comment on lines
-21
to
-22
| declare module '@platformatic/itc' { | ||
| export { ITC } |
Contributor
Author
There was a problem hiding this comment.
Seems to be redundant. Or?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fixing typings of the
ITCConstructorOptionsinterface. The missingname,handlers, andthrowOnMissingHandlerproperties got added based on the runtime implementation:platformatic/packages/itc/lib/index.js
Line 246 in faeb701
I noticed this while migrating type tests to TSTyche. Hope you don’t mind this as a fix and migration in one PR. The type test is written from scratch. It covers all typings from the
.d.tsincluding the new options. The shape of the test is different, but it does everything that the previous test did (and more).