raw_path and query_string should be buffers #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShogunPanda
approved these changes
Oct 6, 2025
Qard
force-pushed
the
fix-asgi-scope-path-and-qs
branch
from
c11ab7a to
65d117d
Compare
In the HttpConnectionScope, the raw_path and query_string attributes actually need to be buffers. Also improved reporting of ASGI failures. Signed-off-by: Stephen Belanger <admin@stephenbelanger.com>
Qard
force-pushed
the
fix-asgi-scope-path-and-qs
branch
from
65d117d to
99fd0ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
HttpConnectionScope, theraw_pathandquery_stringattributes actually need to be buffers. Also improved reporting of ASGI failures.