fix: use virtual cwd with RealFSProvider to prevent path doubling#16
Open
ivan-tymoshenko wants to merge 1 commit intomainfrom
Open
fix: use virtual cwd with RealFSProvider to prevent path doubling#16ivan-tymoshenko wants to merge 1 commit intomainfrom
ivan-tymoshenko wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using RealFSProvider (enabled via fsRootPath), relative paths passed to agent tools resolve against process.cwd() before reaching the provider. If process.cwd() overlaps with the provider root (e.g. both are
/workspaceinside a sandbox), the provider prepends the root again, creating doubled paths like/workspace/workspace/foo.txt.Additionally, the just-bash tool defaults its cwd to
/home/user, causing the model to construct absolute paths like/home/user/foo.txtthat map to/workspace/home/user/foo.txt— wrong and inconsistent with the VFS root.Fixes:
{root}/foo.txt.