Skip to content

fix(cli): flamegraph and cli#113

Merged
mcollina merged 2 commits intoplatformatic:mainfrom
rozzilla:fix/cli/flamegraph-and-cli
Oct 23, 2025
Merged

fix(cli): flamegraph and cli#113
mcollina merged 2 commits intoplatformatic:mainfrom
rozzilla:fix/cli/flamegraph-and-cli

Conversation

@rozzilla
Copy link
Copy Markdown
Contributor

@rozzilla rozzilla commented Oct 23, 2025

  • Do not create/update files outside the build folder
  • Show the flamegraph on full width
  • Properly start the cli command
  • Properly define dependencies
  • Update tests

@rozzilla
fix(cli): flamegraph and cli
110ba51 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
mcollina
mcollina reviewed Oct 23, 2025
View reviewed changes
@rozzilla
update
37c3e86 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla requested a review from mcollina October 23, 2025 10:00
mcollina
mcollina approved these changes Oct 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5f6235c into platformatic:main Oct 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rozzilla @mcollina