Fix start.test.ts to match updated signal handling#122
Merged
Conversation
Updated the test to work with the new signal handling implementation that uses
process.once('SIGINT') instead of close-with-grace. The test now properly:
- Removes close-with-grace mocking
- Mocks client.close() and verifies it's called before server.close()
- Simulates SIGINT using process.emit()
- Mocks setTimeout/clearTimeout to prevent test hangs
- Combines both test scenarios into one to avoid module caching issues
All CLI tests now pass (6/6).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated
test/start.test.tsto work with the new signal handling implementation inlib/start.jsthat usesprocess.once('SIGINT')instead ofclose-with-grace.Changes
client.close()is called beforeserver.close()close-with-graceto testingprocess.once('SIGINT')setTimeoutandclearTimeoutto prevent the 10-minute recording timeout from hanging testscreateis called withsetupSignals: falseTest Results
All CLI tests now pass:
Test Coverage
The updated test verifies:
🤖 Generated with Claude Code