Skip to content

Publishable#59

Merged
mcollina merged 6 commits intomainfrom
publishable
Mar 28, 2025
Merged

Publishable#59
mcollina merged 6 commits intomainfrom
publishable

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Mar 28, 2025

This makes this package distributable as a single module.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina requested a review from Copilot March 28, 2025 10:00
@mcollina
Copy link
Copy Markdown
Member Author

cc @rozzilla

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request prepares the package for distribution as a single module by removing certain generated documentation and configuration files and refining test and linting setups. Key changes include:

  • Removal of auto-generated READMEs and module-specific ESLint configurations for both frontend and backend.
  • Adjustment of test assertions to update the package naming and addition of comments regarding test parallelism.
  • Consolidation of ESLint ignore patterns and CI workflow steps to streamline validation.

Reviewed Changes

Copilot reviewed 11 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web/frontend/eslint.config.js Entire file removed as part of cleaning up redundant configurations.
web/composer/README.md Removed generated documentation no longer needed for distribution.
web/backend/test/routes/root.test.ts Updated test assertion with the new package name.
web/backend/test/plugins/metrics.test.ts Added note (TODO) regarding test parallelism for metrics collection.
web/backend/eslint.config.js Entire file removed in favor of a consolidated linting setup.
web/backend/README.md Removed generated documentation no longer needed for distribution.
eslint.config.js Updated ignore patterns and enabled TypeScript linting.
.github/workflows/ci.yml Revised CI steps to run a consolidated test command.
Files not reviewed (7)
  • package.json: Language not supported
  • web/backend/.gitignore: Language not supported
  • web/backend/package.json: Language not supported
  • web/composer/.gitignore: Language not supported
  • web/composer/package.json: Language not supported
  • web/composer/tsconfig.json: Language not supported
  • web/frontend/package.json: Language not supported
Comments suppressed due to low confidence (3)

web/backend/test/plugins/metrics.test.ts:15

  • [nitpick] The comment notes a limitation in running tests in parallel for metrics. Consider referencing a dedicated issue or adding more context so that this improvement is tracked and addressed in a future update.
  // TODO: fix it and make tests parallel again

eslint.config.js:4

  • Verify that the glob pattern 'web/*/dist' correctly matches all intended distribution directories. Adjust or extend the pattern if additional directories should be ignored.
  ignores: ['node_modules', 'web/*/dist', 'web/frontend/public']

.github/workflows/ci.yml:37

  • The CI workflow now consolidates test execution into a single command. Confirm that this change still provides sufficient isolation and detailed feedback for frontend and backend tests if they have distinct requirements.
      - name: Run tests
          run: npm test

@mcollina mcollina merged commit ed93b86 into main Mar 28, 2025
1 check passed
@mcollina mcollina deleted the publishable branch March 28, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants