Skip to content

feat(backend): calculate metrics for multiple workers#67

Merged
mcollina merged 17 commits intoplatformatic:mainfrom
rozzilla:feat/backend/calculate-metrics-for-multiple-workers
Apr 22, 2025
Merged

feat(backend): calculate metrics for multiple workers#67
mcollina merged 17 commits intoplatformatic:mainfrom
rozzilla:feat/backend/calculate-metrics-for-multiple-workers

Conversation

@rozzilla
Copy link
Copy Markdown
Contributor

@rozzilla rozzilla commented Apr 3, 2025

support for multiple workers of the same service, and update tests

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the math for this is correct. I want to see in the metrics page the data for each of my worker, not having it added up.

@rozzilla rozzilla force-pushed the feat/backend/calculate-metrics-for-multiple-workers branch from 08659f6 to 280d925 Compare April 12, 2025 15:39
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla force-pushed the feat/backend/calculate-metrics-for-multiple-workers branch from 280d925 to bb79f0f Compare April 14, 2025 09:52
@rozzilla
Copy link
Copy Markdown
Contributor Author

I don't think the math for this is correct. I want to see in the metrics page the data for each of my worker, not having it added up.

Yup @mcollina , I need to revisit this code and also expose an object that represents all workers and another that represents the metrics of a specific worker, so that the front end can properly retrieve the data needed.

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla requested a review from mcollina April 14, 2025 17:04
rozzilla added 13 commits April 14, 2025 19:06
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
Copy link
Copy Markdown
Contributor Author

@mcollina, update to support both aggregated and single worker id metrics completed (then the frontend change will follow)

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6c70e9e into platformatic:main Apr 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants