Skip to content

feat(frontend): implement scalar integration#75

Merged
mcollina merged 4 commits intoplatformatic:mainfrom
rozzilla:feat/frontend/implement-scalar-integration
Jun 19, 2025
Merged

feat(frontend): implement scalar integration#75
mcollina merged 4 commits intoplatformatic:mainfrom
rozzilla:feat/frontend/implement-scalar-integration

Conversation

@rozzilla
Copy link
Copy Markdown
Contributor

Fixes #73

QA done ✅
Screenshot 2025-04-19 at 15 06 40
Screenshot 2025-04-19 at 15 06 33
Screenshot 2025-04-19 at 15 06 23

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a rough feeling this is not going to work for nested/not-exposed services. For those, you'd need to route the messages through watt-admin and then through the Control.

@rozzilla
Copy link
Copy Markdown
Contributor Author

I have a rough feeling this is not going to work for nested/not-exposed services. For those, you'd need to route the messages through watt-admin and then through the Control.

I don't see how we can do that using scalar so 🤔

I think we need a slightly better messaging in case there is no OpenAPI for the service, or possibly just a relatively simple UI to send fetch() calls.

Considering the point above, and the fact that scalar adds a lot of dependencies (>13k lines updated in the package-lock.json 😱) and "noise" in the CSS (some classes of the frontend repo were overridden), I suggest we go for the second option, to always have a simple UI to send fetch calls.

This will always work, it will be way slimmer and easy to implement, and users will always see the same interface (rather than scalar for some services, and custom UI for others). @mcollina WDYT?

@mcollina
Copy link
Copy Markdown
Member

We did this before in Meraki: https://github.com/platformatic/meraki. Take a look.

@rozzilla rozzilla force-pushed the feat/frontend/implement-scalar-integration branch 2 times, most recently from 837dfa0 to bc823d0 Compare June 9, 2025 10:21
@rozzilla rozzilla force-pushed the feat/frontend/implement-scalar-integration branch from 79d34ff to 3bf8cd3 Compare June 11, 2025 14:03
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

update

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

update

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

update

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

update

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

chore update css

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

update

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

update

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla force-pushed the feat/frontend/implement-scalar-integration branch from c832300 to 479a571 Compare June 11, 2025 14:30
@rozzilla
Copy link
Copy Markdown
Contributor Author

We did this before in Meraki: https://github.com/platformatic/meraki. Take a look.

@mcollina updated with a similar approach (using an internal /proxy endpoint)

@rozzilla rozzilla requested a review from mcollina June 11, 2025 14:32
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@mcollina
Copy link
Copy Markdown
Member

Screenshot 2025-06-17 at 16 28 53

Is it possible to remove the /api/proxy/32620/services/service as shown here?


Screenshot 2025-06-17 at 16 30 21

Looking at this, is this possible to add some text like "Open it at http://.."

@rozzilla
Copy link
Copy Markdown
Contributor Author

Screenshot 2025-06-17 at 16 28 53 Is it possible to remove the `/api/proxy/32620/services/service` as shown here?

I see it in the image you shared. I don't get what I should update...

Screenshot 2025-06-17 at 16 30 21 Looking at this, is this possible to add some text like "Open it at http://.."

It's not clear to me what URL I should show here 🤔

rozzilla added 2 commits June 19, 2025 15:40
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
Copy link
Copy Markdown
Contributor Author

@mcollina updated ✅

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 1d65869 into platformatic:main Jun 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-it button does not work

2 participants