Skip to content

feat(backend): add more endpoints#8

Merged
mcollina merged 7 commits intoplatformatic:mainfrom
rozzilla:feat/backend/add-more-endpoints
Dec 31, 2024
Merged

feat(backend): add more endpoints#8
mcollina merged 7 commits intoplatformatic:mainfrom
rozzilla:feat/backend/add-more-endpoints

Conversation

@rozzilla
Copy link
Copy Markdown
Contributor

@rozzilla rozzilla commented Dec 30, 2024

image

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla force-pushed the feat/backend/add-more-endpoints branch from ed9a4d2 to e63c64e Compare December 30, 2024 16:00
@rozzilla rozzilla marked this pull request as draft December 30, 2024 16:38
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla requested a review from mcollina December 31, 2024 09:05
@rozzilla rozzilla marked this pull request as ready for review December 31, 2024 09:05

export default async function (fastify: FastifyInstance, opts: FastifyPluginOptions) {
fastify.addHook('onClose', async () => {
// FIXME: this is an issue on wattpm, since graceful shutdown time of 10s isn't considered (https://docs.platformatic.dev/docs/runtime/configuration#gracefulshutdown)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla requested a review from mcollina December 31, 2024 17:43
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0e7c20e into platformatic:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants