Conversation
|
Analyzed 1026 tracker script variants for size changes. Main variants:
Important legacy variants:
Summary:
In total, 378 variants brotli size increased and 256 variants brotli size decreased. |
c100ba0 to
f3e2022
Compare
a9f0e49 to
ac2a119
Compare
6db2136 to
f25673e
Compare
Note that since the module uses only vanilla es5 outside the export, it's safe to just append to the minified output
Running into too big rabbit holes trying to get it off the ground
7c1b61f to
5e7f7de
Compare
1b32310 to
b514c00
Compare
As the compiler currently manages to compile everything in ~3 seconds, the `features`/`compileIds` feature serves no more point. Scrapping it
1e5a750 to
6d867b1
Compare
apata
left a comment
There was a problem hiding this comment.
I like this! I appreciate the shared tests and that the npm module is tested at all. Lots of removed lines and small nuisances fixed.
| @@ -0,0 +1,243 @@ | |||
| /* | |||
There was a problem hiding this comment.
Less repetition in tests, very nice!
Co-authored-by: Artur Pata <artur.pata@gmail.com>
|
If you search Google for "Plausible npm", the old package is still returned, and the new one isn't in the results at all. Most people are still downloading the old script rather than the new one, based on npm download stats. Do you have plans to mark the old one as deprecated at some point? |
Depends on #5449. If that gets rejected, I will rebase accordingly.
This PR is the start of work for creating a new NPM library for our tracker script off of the same tracker codebase.
It:
Work left for the future:
The PR also: