Conversation
|
Analyzed 1025 tracker script variants for size changes. Main variants:
Important legacy variants:
Summary:
In total, 1014 variants brotli size increased and 8 variants brotli size decreased. |
|
Fleshing out the benefits and drawbacks more, I see the following
@macobo Did you already try organizing the code in the single file? If you did and found it still hard to comprehend, then I think the drawbacks, small as they are, are acceptable. Even if you didn't try that, I'd be ok with us proceeding with rollup for sake of development velocity. |
There was a problem hiding this comment.
After going through the changes, it is easier to understand now, especially engagement. Good job!
I'm worried that I might have missed some accidental changes during the refactor though, for features that the tests don't cover. Third set of eyes on this maybe?
Edit: Ah, I see that there was already a third set of eyes on it, good!
a9f0e49 to
ac2a119
Compare
Changes
This PR proposes using rollup as a bundler for tracker script.
Benefit:
Drawbacks:
config.domain/config.endpoint/config.autoCapturePageviewsover vars and new function definitions - this doesn't minify as nicely. See comment below for stats.Best reviewed commit-by-commit.