Skip to content

Fix invalid onIgnoredEvent call#5462

Closed
apata wants to merge 2 commits intomasterfrom
script-v2/fix-invalid-on-ignore-event
Closed

Fix invalid onIgnoredEvent call#5462
apata wants to merge 2 commits intomasterfrom
script-v2/fix-invalid-on-ignore-event

Conversation

@apata
Copy link
Copy Markdown
Contributor

@apata apata commented Jun 3, 2025 •
edited
Loading

Changes

The arguments of an onIgnoredEvent call are in the wrong order.

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@apata apata requested a review from a team June 3, 2025 12:45
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 3, 2025

Analyzed 1025 tracker script variants for size changes.
The following tables summarize the results, with comparison with the baseline version in parentheses.

Main variants:

Brotli Gzip Uncompressed
plausible-web.js 2282B (+0B / 0%) 2608B (-3B / -0.1%) 6030B (+0B / 0%)

Important legacy variants:

Brotli Gzip Uncompressed
plausible.js 1116B (+0B / 0%) 1294B (-4B / -0.3%) 2731B (+0B / 0%)
plausible.hash.js 1084B (+0B / 0%) 1264B (-4B / -0.3%) 2623B (+0B / 0%)
plausible.pageview-props.tagged-events.js 1824B (-2B / -0.1%) 2107B (-3B / -0.1%) 4663B (+0B / 0%)
plausible.file-downloads.hash.pageview-props.revenue.js 1638B (+0B / 0%) 1925B (-3B / -0.2%) 4005B (+0B / 0%)
plausible.compat.exclusions.file-downloads.outbound-links.pageview-props.revenue.tagged-events.js 2222B (-2B / -0.1%) 2614B (-5B / -0.2%) 5799B (+0B / 0%)

Summary:

Brotli Gzip Uncompressed
Largest variant (plausible.compat.exclusions.file-downloads.outbound-links.pageview-props.revenue.tagged-events.js) 2222B (-2B / -0.1%) 2614B (-5B / -0.2%) 5799B (+0B / 0%)
Max change (plausible.exclusions.hash.local.outbound-links.revenue.tagged-events.js) 1836B (+20B / +1.1%) 2134B (-3B / -0.1%) 4795B (+0B / 0%)
Min change (plausible.compat.exclusions.file-downloads.local.manual.pageview-props.revenue.tagged-events.js) 1954B (-13B / -0.7%) 2304B (-5B / -0.2%) 5010B (+0B / 0%)
Median change 1675B (+0B / 0%) 1977B (-4B / -0.2%) 4187B (+0B / 0%)

In total, 202 variants brotli size increased and 349 variants brotli size decreased.

@apata apata changed the title Fix invalid onIgnoreEvent call Fix invalid onIgnoredEvent call Jun 3, 2025
macobo added a commit that referenced this pull request Jun 4, 2025
@macobo
Cherry-pick PR #5462
a38e22d
@macobo
Copy link
Copy Markdown
Contributor

macobo commented Jun 4, 2025

Good catch, thanks! This runs into conflict with #5449, bundled the change in there and will merge it as part of that branch.

@macobo macobo closed this Jun 4, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2025
@macobo
Proposal: ScriptV2 bundler (#5449)
426ae49 
* Experiment with rollup bundler

* WIP: Unbundle

* Always allow overriding url with options.u

* fix conditional

* Update manual conditional #2

* Unbundle custom events code

* Unbundle autocapturing of pageviews

* Comment Object.assign

* Rename functions in compiler

* Rename trigger -> track, unbundle

* Dont rely on window.plausible in custom-events.js

* chore: Bump tracker_script_version to 14

* Cherry-pick PR #5462
@apata apata deleted the script-v2/fix-invalid-on-ignore-event branch February 11, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apata @macobo