Conversation
0048ba5 to
31a780d
Compare
b80aa08 to
43c0273
Compare
2470096 to
e6e5018
Compare
apata
reviewed
Mar 5, 2026
apata
reviewed
Mar 5, 2026
apata
reviewed
Mar 5, 2026
4 tasks
apata
reviewed
Mar 7, 2026
apata
reviewed
Mar 7, 2026
apata
approved these changes
Mar 7, 2026
Contributor
apata
left a comment
There was a problem hiding this comment.
Nice work! I like the sensible test data, makes the dashboard look good when running the tests in headed mode
…types Fix typescript errors, finetune mix alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR extends previously setup E2E test suite to cover major extent of dashboard interactions.
We don't cover all the possible states, mostly focusing on "happy" paths.
The changes in the frontend code are limited to:
The missing coverage any cases of greater significance can be added in follow-ups as this PR is already huge. We might add more tests for less usual interaction paths but we will have to strike a balance to avoid inflating the test suite and slowing down the CI pipeline too much.
The top level tests number is kept relatively low (currently between 40-50) as state setup is usually the expensive part of the process. We might consider replacing frontend-centric fixtures setting up user and site via forms on the page with dedicated e2e endpoints in the future to reduce the time spent on it if that becomes too much of a burden (we might still keep the existing fixtures and use them only for a couple general tests to keep covering areas outside the dashboard by extension). We make extensive use of
test.stepto cram more test cases in each test. This means there are effectively more test cases than the report implies.NOTE: CI is currently failing due to unrelated tests failing (they fail across other branches too). I'll have a look at them independently.Fixed!Tests