Skip to content

Extend E2E dashboard tests#6077

Merged
zoldar merged 72 commits intomasterfrom
e2e-feature-tests-redux
Mar 9, 2026
Merged

Extend E2E dashboard tests#6077
zoldar merged 72 commits intomasterfrom
e2e-feature-tests-redux

Conversation

@zoldar
Copy link
Copy Markdown
Contributor

@zoldar zoldar commented Feb 17, 2026

Changes

This PR extends previously setup E2E test suite to cover major extent of dashboard interactions.

We don't cover all the possible states, mostly focusing on "happy" paths.

The changes in the frontend code are limited to:

  • adding "data-testid" attributes (and one instance of extra "data-" attribute for determining state of tab more easily)
  • adding aria labels/labelledby where it makes sense

The missing coverage any cases of greater significance can be added in follow-ups as this PR is already huge. We might add more tests for less usual interaction paths but we will have to strike a balance to avoid inflating the test suite and slowing down the CI pipeline too much.

The top level tests number is kept relatively low (currently between 40-50) as state setup is usually the expensive part of the process. We might consider replacing frontend-centric fixtures setting up user and site via forms on the page with dedicated e2e endpoints in the future to reduce the time spent on it if that becomes too much of a burden (we might still keep the existing fixtures and use them only for a couple general tests to keep covering areas outside the dashboard by extension). We make extensive use of test.step to cram more test cases in each test. This means there are effectively more test cases than the report implies.

NOTE: CI is currently failing due to unrelated tests failing (they fail across other branches too). I'll have a look at them independently. Fixed!

Tests

  • Automated tests definitely have been added

@zoldar zoldar force-pushed the e2e-feature-tests-redux branch 7 times, most recently from 0048ba5 to 31a780d Compare February 23, 2026 15:16
@zoldar zoldar force-pushed the e2e-feature-tests-redux branch 9 times, most recently from b80aa08 to 43c0273 Compare March 4, 2026 14:13
@zoldar zoldar requested a review from a team March 5, 2026 11:34
@zoldar zoldar marked this pull request as ready for review March 5, 2026 11:34
@zoldar zoldar force-pushed the e2e-feature-tests-redux branch from 2470096 to e6e5018 Compare March 5, 2026 12:53
Copy link
Copy Markdown
Contributor

@apata apata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I like the sensible test data, makes the dashboard look good when running the tests in headed mode

@zoldar zoldar added this pull request to the merge queue Mar 9, 2026
Merged via the queue into master with commit 42071aa Mar 9, 2026
24 checks passed
@zoldar zoldar deleted the e2e-feature-tests-redux branch March 9, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants