Fix typescript errors, finetune mix alias#6138
Merged
apata merged 8 commits intoe2e-feature-tests-reduxfrom Mar 8, 2026
Merged
Fix typescript errors, finetune mix alias#6138apata merged 8 commits intoe2e-feature-tests-reduxfrom
apata merged 8 commits intoe2e-feature-tests-reduxfrom
Conversation
apata
commented
Mar 7, 2026
Comment on lines
+212
to
+217
| - name: Check format | ||
| run: npm --prefix ./e2e run check-format | ||
|
|
||
| - name: Check types | ||
| run: npm --prefix ./e2e run typecheck | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Runs once in every shard, so it's a bit wasteful, but I really want these to be enforced
zoldar
approved these changes
Mar 7, 2026
Contributor
zoldar
left a comment
zoldar
left a comment
There was a problem hiding this comment.
Awesome. Thanks for taking time ironing out the typing ❤️ And the mix task accepting arguments is definitely a better option, thanks for that as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Against #6077
Tests
Changelog
Documentation
Dark mode