When destroying application sends onAssetChanged and Data is null

[lukasharing]

engine/src/framework/components/component.js

Line 48 in d3d8430

return this.data[name];

[mvaligursky]

Hi @lukasharing - would you have any repro project for this? That would make it a lot easier to fix. Thanks!

[yaustar]

I also noticed that you are on engine 1.46.5. Is this issue reproducible on a more recent version of the engine?

[lukasharing]

It is reproducible on the '1.51.5' version

although the name of the file is 1.46, i have override the content :)

[lukasharing]

The destroy function of an animation should first remove every event and then unload the asset

[lukasharing]

The lines:

engine/src/framework/components/animation/component.js

Lines 283 to 289 in d3d8430

	onAssetChanged(asset, attribute, newValue, oldValue) {
	if (attribute === 'resource' || attribute === 'resources') {
	// If the attribute is 'resources', newValue can be an empty array when the
	// asset is unloaded. Therefore, we should assign null in this case
	if (attribute === 'resources' && newValue && newValue.length === 0) {
	newValue = null;
	}

The fix:

if ((attribute === 'resource' || attribute === 'resources') && this.data) {

[mvaligursky]

Would you have a repro project we could investigate this on?

[lukasharing]

You could try the game here:
https://playcanvas.com/project/666521/overview/color-bee

[yaustar]

Just had a look at the project posted and cannot reproduce the issue when calling pc.app.destroy() in the console

[lukasharing]

I manage to fix it by checking this:

if ((attribute === 'resource' || attribute === 'resources') && this.data) {

I can reproduce it by playing on our emulator

[yaustar]

Sorry, I don't understand how you've fixed it on the project side?

[lukasharing]

engine/src/framework/components/animation/component.js

Lines 283 to 284 in d3d8430

	onAssetChanged(asset, attribute, newValue, oldValue) {
	if (attribute === 'resource' || attribute === 'resources') {

Yes i have override this method on my side :

window.pc.AnimationComponent.prototype.onAssetChanged = function(asset, attribute, newValue, oldValue) {
        if ((attribute === 'resource' || attribute === 'resources') && this.data) { /// now we check if this.data exists