Skip to content

[FIX] Cubemap filtering on safari#2288

Merged
slimbuck merged 1 commit intoplaycanvas:masterfrom
slimbuck:safari-cubemap-filter-fix
Jul 15, 2020
Merged

[FIX] Cubemap filtering on safari#2288
slimbuck merged 1 commit intoplaycanvas:masterfrom
slimbuck:safari-cubemap-filter-fix

Conversation

@slimbuck
Copy link
Copy Markdown
Member

Explicitly set cubemap filtering on safari.

I confirm I have signed the Contributor License Agreement.

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Jul 15, 2020
@slimbuck slimbuck requested a review from a team July 15, 2020 10:42
@slimbuck slimbuck self-assigned this Jul 15, 2020
@slimbuck slimbuck merged commit 2f43a59 into playcanvas:master Jul 15, 2020
@slimbuck slimbuck deleted the safari-cubemap-filter-fix branch July 15, 2020 10:45
@willeastcott
Copy link
Copy Markdown
Contributor

You mean addressing, right? 😄

TheJonRobinson added a commit to Mojiworks/playcanvas-engine that referenced this pull request Jul 15, 2020
* mojiworks/pr/sound-stop-typing: (112 commits)
  fix: SoundComponent.stop's string parameter is optional
  [RELEASE] v1.32.0
  [Fix] Changes to Attribute to location mapping (playcanvas#2292)
  Deprecate pc.makeArray (playcanvas#2289)
  [FIX] API ref docs for pc.Mesh#getIndices (playcanvas#2291)
  fix cubemap filtering on safari (playcanvas#2288)
  disable ImageBitmap (playcanvas#2286)
  [Fix] Fix to texture based skinning on Safari (playcanvas#2287)
  fix cubemap dependent loads (playcanvas#2285)
  [Fix] Update to Transform Feedback to work with VAOs (playcanvas#2284)
  Update the anim state graph to support the new data schema (playcanvas#2278)
  Remove viewer (playcanvas#2282)
  [FIX] pc.SoundComponent#resume/stop param type (playcanvas#2281)
  Remove type function (playcanvas#2273)
  Remove some shader-related circular dependencies (playcanvas#2274)
  Glb-parser improvements (playcanvas#2275)
  Fix glb-parser normals generation (playcanvas#2276)
  Glb texture coordinate fix (playcanvas#2252)
  use faces if the asset was previously unloaded (playcanvas#2272)
  fix material resource loader (playcanvas#2268)
  ...

# Conflicts:
#	src/scene/graph-node.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Graphics related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants