Deprecate pc.makeArray#2289
Conversation
slimbuck
left a comment
slimbuck
left a comment
There was a problem hiding this comment.
I'm wondering whether we could place timings on deprecated items saying they will be removed at such-and-such a date? Currently everyone pays the price of deprecated code.
|
That's one option. But it may be that it's unnecessary to ever remove deprecated stuff and instead just provide a legacy build and a non-legacy build. That's now easy with rollup - we just add another target minus the |
* mojiworks/pr/sound-stop-typing: (112 commits) fix: SoundComponent.stop's string parameter is optional [RELEASE] v1.32.0 [Fix] Changes to Attribute to location mapping (playcanvas#2292) Deprecate pc.makeArray (playcanvas#2289) [FIX] API ref docs for pc.Mesh#getIndices (playcanvas#2291) fix cubemap filtering on safari (playcanvas#2288) disable ImageBitmap (playcanvas#2286) [Fix] Fix to texture based skinning on Safari (playcanvas#2287) fix cubemap dependent loads (playcanvas#2285) [Fix] Update to Transform Feedback to work with VAOs (playcanvas#2284) Update the anim state graph to support the new data schema (playcanvas#2278) Remove viewer (playcanvas#2282) [FIX] pc.SoundComponent#resume/stop param type (playcanvas#2281) Remove type function (playcanvas#2273) Remove some shader-related circular dependencies (playcanvas#2274) Glb-parser improvements (playcanvas#2275) Fix glb-parser normals generation (playcanvas#2276) Glb texture coordinate fix (playcanvas#2252) use faces if the asset was previously unloaded (playcanvas#2272) fix material resource loader (playcanvas#2268) ... # Conflicts: # src/scene/graph-node.js
|
Taking in account some deprecated stuff is still within code, for example WebVR - is deprecated, but still there. One argument would be "but we add another define", yep. But we probably could combine PROFILE and DEBUG into same target. But probably, legacy should be still a default engine for most people, to avoid unnecessary confusion "why it suddenly breaks". And provide Launch and Publish options, to run without LEGACY stuff. |
|
Yeah, that's certainly one option. We do need to deal with:
|
|
Sad to see Zone component to go away, it definitely worth re-thinking it, as often wanted to separate spaces in zones, and do some clustering, and other logic based on them (fill zone with probes e.g.). |
|
It's not guaranteed we'll get rid of the zone component. But right now, there's little to no benefit from it. |
3 participants
pc.makeArrayis private API. But it's pretty useless considering its behavior can be achieved withArray.prototype.slice.call. It's been officially moved todeprecated.js.I confirm I have signed the Contributor License Agreement.