fix: use unfilterable-float sample type for RGBA32F textures in node culling shader#8553
Merged
mvaligursky merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
…culling shader iOS doesn't support the float32-filterable WebGPU feature, so RGBA32F textures must use unfilterable-float in the bind group layout. Use the engine's custom 'uff' type annotation which produces the correct bind group layout while emitting valid texture_2d<f32> WGSL. Made-with: Cursor
mvaligursky
pushed a commit
that referenced
this pull request
Mar 25, 2026
…n WebGPU Fixed #8553 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS doesn't support the
float32-filterableWebGPU feature, sorgba32floattextures cannot be bound withsampleType: "float"in the bind group layout — they requiresampleType: "unfilterable-float".Changes:
boundsSphereTextureandtransformsTexturedeclarations fromtexture_2d<f32>totexture_2d<uff>in the WGSL node culling shaderufftype annotation produces the correctunfilterable-floatbind group layout while emitting validtexture_2d<f32>WGSL for the GPUtextureLoad(no filtering needed)