fix(gsplat): avoid GLSL ES reserved word 'packed' in compact format shader#8737
Merged
Conversation
…hader `packed` is reserved in GLSL ES 3.00+ (§3.7). The current stable ANGLE shader compiler accepts it, but the newer ANGLE in Chrome Canary correctly rejects it, breaking gsplat rendering with: ERROR: 'packed' : Illegal use of reserved word ERROR: 'packed' : syntax error Rename the offending locals/parameters to `data` in the GLSL chunks, and apply the same renames to the matching WGSL chunks to keep the GLSL/WGSL pair symmetric. No public API or behaviour change.
willeastcott
pushed a commit
that referenced
this pull request
May 24, 2026
…hader (#8737) `packed` is reserved in GLSL ES 3.00+ (§3.7). The current stable ANGLE shader compiler accepts it, but the newer ANGLE in Chrome Canary correctly rejects it, breaking gsplat rendering with: ERROR: 'packed' : Illegal use of reserved word ERROR: 'packed' : syntax error Rename the offending locals/parameters to `data` in the GLSL chunks, and apply the same renames to the matching WGSL chunks to keep the GLSL/WGSL pair symmetric. No public API or behaviour change. Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
willeastcott
pushed a commit
that referenced
this pull request
May 24, 2026
…hader (#8737) `packed` is reserved in GLSL ES 3.00+ (§3.7). The current stable ANGLE shader compiler accepts it, but the newer ANGLE in Chrome Canary correctly rejects it, breaking gsplat rendering with: ERROR: 'packed' : Illegal use of reserved word ERROR: 'packed' : syntax error Rename the offending locals/parameters to `data` in the GLSL chunks, and apply the same renames to the matching WGSL chunks to keep the GLSL/WGSL pair symmetric. No public API or behaviour change. Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compact gsplat format read chunk used a local variable named
packed, which is a reserved keyword in GLSL ES 3.00+ (§3.7). The current stable ANGLE shader compiler in Chrome accepts it, but the newer ANGLE in Chrome Canary correctly rejects it, breaking gsplat rendering:Fix:
glsl/chunks/gsplat/vert/formats/containerCompactRead.js— rename the three localuint packeddeclarations (ingetColor,getRotation,getScale) and their uses todata.glsl/chunks/gsplat/vert/formats/uncompressed.js— rename thevec3 packedparameter onunpackRotationand its uses todata.wgsl/chunks/gsplat/vert/formats/containerCompactRead.js,wgsl/chunks/gsplat/vert/formats/uncompressed.js) renamed identically so the GLSL/WGSL pair stays symmetric. WGSL itself doesn't reservepacked, but keeping the names in sync makes the chunks easier to maintain.No public API changes, no behaviour changes.