Skip to content

fix(gsplat): avoid GLSL ES reserved word 'packed' in compact format shader #8737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvaligursky merged 1 commit into from
May 17, 2026
Merged

fix(gsplat): avoid GLSL ES reserved word 'packed' in compact format shader #8737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/scene/shader-lib/glsl/chunks/gsplat/vert/formats/containerCompactRead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@ float getOpacity() {
}

vec3 getColor() {
uint packed = loadDataColor().x;
float r = float(packed & 0x7FFu) * (4.0 / 2047.0);
float g = float((packed >> 11u) & 0x7FFu) * (4.0 / 2047.0);
float b = float((packed >> 22u) & 0x3FFu) * (4.0 / 1023.0);
uint data = loadDataColor().x;
float r = float(data & 0x7FFu) * (4.0 / 2047.0);
float g = float((data >> 11u) & 0x7FFu) * (4.0 / 2047.0);
float b = float((data >> 22u) & 0x3FFu) * (4.0 / 1023.0);
return vec3(r, g, b);
}

vec4 getRotation() {
uint packed = loadDataTransformB().x;
uint data = loadDataTransformB().x;

// dequantize half-angle projected quaternion: 11+11+10 bits to [-1, 1]
vec3 p = vec3(
float(packed & 0x7FFu) / 2047.0 * 2.0 - 1.0,
float((packed >> 11u) & 0x7FFu) / 2047.0 * 2.0 - 1.0,
float((packed >> 22u) & 0x3FFu) / 1023.0 * 2.0 - 1.0
float(data & 0x7FFu) / 2047.0 * 2.0 - 1.0,
float((data >> 11u) & 0x7FFu) / 2047.0 * 2.0 - 1.0,
float((data >> 22u) & 0x3FFu) / 1023.0 * 2.0 - 1.0
);

// inverse half-angle transform, returns (w, x, y, z) format
Expand All @@ -40,10 +40,10 @@ vec4 getRotation() {
}

vec3 getScale() {
uint packed = cachedTransformA.a;
float sx = float(packed & 0xFFu);
float sy = float((packed >> 8u) & 0xFFu);
float sz = float((packed >> 16u) & 0xFFu);
uint data = cachedTransformA.a;
float sx = float(data & 0xFFu);
float sy = float((data >> 8u) & 0xFFu);
float sz = float((data >> 16u) & 0xFFu);

// decode log-encoded scale: 0 = true zero, 1-255 maps linearly in log-space to e^-12..e^9
const float logRange = 21.0 / 255.0;
Expand Down
4 changes: 2 additions & 2 deletions src/scene/shader-lib/glsl/chunks/gsplat/vert/formats/uncompressed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export default /* glsl */`
uint tAw;
vec4 tBcached;

vec4 unpackRotation(vec3 packed) {
return vec4(packed.xyz, sqrt(max(0.0, 1.0 - dot(packed, packed))));
vec4 unpackRotation(vec3 data) {
return vec4(data.xyz, sqrt(max(0.0, 1.0 - dot(data, data))));
}

// read the model-space center of the gaussian
Expand Down
24 changes: 12 additions & 12 deletions src/scene/shader-lib/wgsl/chunks/gsplat/vert/formats/containerCompactRead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@ fn getOpacity() -> f32 {
}

fn getColor() -> vec3f {
let packed = loadDataColor().x;
let r = f32(packed & 0x7FFu) * (4.0 / 2047.0);
let g = f32((packed >> 11u) & 0x7FFu) * (4.0 / 2047.0);
let b = f32((packed >> 22u) & 0x3FFu) * (4.0 / 1023.0);
let data = loadDataColor().x;
let r = f32(data & 0x7FFu) * (4.0 / 2047.0);
let g = f32((data >> 11u) & 0x7FFu) * (4.0 / 2047.0);
let b = f32((data >> 22u) & 0x3FFu) * (4.0 / 1023.0);
return vec3f(r, g, b);
}

fn getRotation() -> vec4f {
let packed = loadDataTransformB().x;
let data = loadDataTransformB().x;

// dequantize half-angle projected quaternion: 11+11+10 bits to [-1, 1]
let p = vec3f(
f32(packed & 0x7FFu) / 2047.0 * 2.0 - 1.0,
f32((packed >> 11u) & 0x7FFu) / 2047.0 * 2.0 - 1.0,
f32((packed >> 22u) & 0x3FFu) / 1023.0 * 2.0 - 1.0
f32(data & 0x7FFu) / 2047.0 * 2.0 - 1.0,
f32((data >> 11u) & 0x7FFu) / 2047.0 * 2.0 - 1.0,
f32((data >> 22u) & 0x3FFu) / 1023.0 * 2.0 - 1.0
);

// inverse half-angle transform, returns (w, x, y, z) format
Expand All @@ -40,10 +40,10 @@ fn getRotation() -> vec4f {
}

fn getScale() -> vec3f {
let packed = cachedTransformA.a;
let sx = f32(packed & 0xFFu);
let sy = f32((packed >> 8u) & 0xFFu);
let sz = f32((packed >> 16u) & 0xFFu);
let data = cachedTransformA.a;
let sx = f32(data & 0xFFu);
let sy = f32((data >> 8u) & 0xFFu);
let sz = f32((data >> 16u) & 0xFFu);

// decode log-encoded scale: 0 = true zero, 1-255 maps linearly in log-space to e^-12..e^9
let logRange = 21.0 / 255.0;
Expand Down
4 changes: 2 additions & 2 deletions src/scene/shader-lib/wgsl/chunks/gsplat/vert/formats/uncompressed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export default /* wgsl */`
var<private> tAw: u32;
var<private> tBcached: vec4f;

fn unpackRotation(packed: vec3f) -> vec4f {
return vec4f(packed.xyz, sqrt(max(0.0, 1.0 - dot(packed, packed))));
fn unpackRotation(data: vec3f) -> vec4f {
return vec4f(data.xyz, sqrt(max(0.0, 1.0 - dot(data, data))));
}

// read the model-space center of the gaussian
Expand Down