Remove unused BatchManager#clone method - #9106
Merged
Merged
Conversation
Build size reportThis PR changes the size of the minified bundles.
|
BatchManager#clone was never called anywhere in the engine's history (introduced as speculative API and never wired up) and had no supported use case. Replace the implementation with a Debug.removed() notice, matching the existing Batch#model removal pattern.
mvaligursky
force-pushed
the
mv-remove-batch-clone
branch
from
July 23, 2026 13:21
686430f to
a6b5724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
BatchManager#clonemethod, replacing its body with aDebug.removed()notice (matching the existingBatch#modelremoval pattern).Changes:
BatchManager#clone(batch, clonedMeshInstances)has never been called anywhere in the engine's history — it was introduced as speculative API (originallycloneBatch) and never wired into any code path.API Changes:
BatchManager#clone. The method now logs a "removed" message viaDebug.removed()and returns nothing. There is no replacement — batches are (re)generated through batch groups /BatchManager.generate(), and hardware instancing covers cheap duplication of shared geometry.