Fix painter example render target orientation across APIs - #9108
Merged
Conversation
The painter example rendered brush strokes into a render target created with the default (API-native) orientation, then sampled that texture with mesh UVs on the display box. Because native storage differs between WebGL2 (bottom-up) and WebGPU (top-down), the painted result appeared vertically mirrored between the two backends. Set the render target origin to RENDERTARGET_ORIGIN_TOP so the painted texture is stored in image orientation on both APIs, making the example render identically everywhere.
Build size reportThis PR does not change the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
painterexample rendered brush strokes into a render target created with the default (API-native) orientation, then sampled that texture with mesh UVs on the display box. Since native storage differs between WebGL2 (bottom-up) and WebGPU (top-down), the painted result appeared vertically mirrored between the two backends.Fix: create the render target with
origin: RENDERTARGET_ORIGIN_TOPso the painted texture is stored in image orientation on both APIs, making the example render identically everywhere. This also models the recommended pattern (useoriginfor render targets sampled as textures) now thatRenderTarget#flipYis deprecated.Changes:
examples/graphics/painter: render target created withorigin: RENDERTARGET_ORIGIN_TOP.Verified on WebGL2 and WebGPU (identical result after the fix).