Expose Bayer 2/4 dither modes and add Bayer 16 dither mode - #9117
Merged
Conversation
Build size reportThis PR changes the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6097. The engine already had
bayer2/bayer4GLSL/WGSL helper functions implemented but unreachable, and no way to get a coarser or finer ordered-dither pattern than the existing Bayer 8. This addsDITHER_BAYER2andDITHER_BAYER4as selectable opacity dither modes, and introduces a newDITHER_BAYER16mode for finer dithering.Changes:
DITHER_BAYER2andDITHER_BAYER4constants, wiring up the existingbayer2()/bayer4()shader functions to theopacityDitherchunk (GLSL + WGSL)DITHER_BAYER16constant and a newbayer16()function (GLSL + WGSL), extending the existing Bayer matrix recursionStandardMaterial#opacityDither/#opacityShadowDitherJSDoc to document the new modesAPI Changes:
DITHER_BAYER2,DITHER_BAYER4,DITHER_BAYER16Examples:
materials/material-transparency: added Bayer2, Bayer4 and Bayer16 columns alongside the existing dither modesgraphics/dithered-transparency: added Bayer2, Bayer4 and Bayer16 to the Dither Color / Dither Shadow dropdowns