Expose the new volumetric fog settings on the camera-frame script - #9138
Merged
Conversation
Build size reportThis PR does not change the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9137, which added volumetric scattering from the clustered omni and spot lights but left the settings reachable only from code. This exposes them as attributes of the
camera-frameESM script, so Editor users can enable and tune the effect from the inspector.localIntensityandlocalStepsare only shown once one of the two light types is enabled. The Editor's attribute conditions support full expressions (&&,||, grouping), which is what makes the nested condition possible.While comparing every
CameraFramesettings group against the script, three unrelated gaps turned up in the same file and are fixed here as well.Changes:
volumetricFoggainslocalOmniLights,localSpotLights,localIntensity,localStepsandextinction, completing the group - it now covers all 18 properties of the engine'sCameraFrame.volumetricFog.lightis documented as optional, matching Add volumetric fog support for clustered omni and spot lights #9137 - leaving it unset lights the fog by the local lights and the ambient term alone.ssao.blurEnablednever being applied. The attribute was declared, so the Editor showed the toggle, but it was missing from the settings that get copied to theCameraFrameand had no effect.ssao.randomizeattribute, the alternative to blurring when TAA is enabled.VolumetricFog. It was the only settings group class left out of the export list, so unlike its ten siblings it got no page in the scripts API reference.API Changes:
VolumetricFogis now exported fromscripts/esm/camera-frame.mjs.Performance: