Detach element component graph nodes on destroy - #9183
Merged
Conversation
The image and text element internals parent a GraphNode to their entity, but neither detached it on destroy, so it stayed in entity.children for the lifetime of the entity.
Build size reportThis PR changes the size of the minified bundles.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Detaches internal element graph nodes during destruction to prevent stale children from accumulating.
Changes:
- Detach image and text graph nodes on destroy.
- Add regression tests for type changes and component removal.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/framework/components/element/image-element.js |
Detaches the image render node during cleanup. |
src/framework/components/element/text-element.js |
Detaches the text render node during cleanup. |
test/framework/components/element/component.test.mjs |
Tests node cleanup across type changes and removal. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image and text element internals parent a
GraphNodeto their entity, but neither detached it on destroy. The node therefore stayed inentity.childrenfor the lifetime of the entity - soremoveComponent('element')left one behind, and everyelement.typechange added another. This is the accumulating half of #4333.Changes:
ImageRenderable#destroyandTextElement#destroynow detach their graph node from the entity, matching whatSpriteComponentalready does.