Use Geometry#calculateTangents in procedural geometry subclasses

src/scene/geometry/box-geometry.js

@@ -1,5 +1,4 @@
 import { Vec3 } from '../../core/math/vec3.js';
-import { calculateTangents } from './geometry-utils.js';
 import { Geometry } from './geometry.js';
 
 const primitiveUv1Padding = 8.0 / 64;
@@ -175,7 +174,7 @@ class BoxGeometry extends Geometry {
         this.indices = indices;
 
         if (opts.calculateTangents) {
-            this.tangents = calculateTangents(positions, normals, uvs, indices);
+            this.calculateTangents();
         }
     }
 }

src/scene/geometry/capsule-geometry.js

@@ -1,5 +1,4 @@
 import { ConeBaseGeometry } from './cone-base-geometry.js';
-import { calculateTangents } from './geometry-utils.js';
 
 /**
  * A procedural capsule-shaped geometry.
@@ -69,7 +68,7 @@ class CapsuleGeometry extends ConeBaseGeometry {
         super(radius, radius, height - 2 * radius, heightSegments, sides, true);
 
         if (opts.calculateTangents) {
-            this.tangents = calculateTangents(this.positions, this.normals, this.uvs, this.indices);
+            this.calculateTangents();
         }
     }
 }

src/scene/geometry/circle-geometry.js

@@ -1,4 +1,3 @@
-import { calculateTangents } from './geometry-utils.js';
 import { Geometry } from './geometry.js';
 
 /**
@@ -119,7 +118,7 @@ class CircleGeometry extends Geometry {
         this.indices = indices;
 
         if (opts.calculateTangents) {
-            this.tangents = calculateTangents(positions, normals, uvs, indices);
+            this.calculateTangents();
         }
     }
 }

src/scene/geometry/cone-geometry.js

@@ -1,5 +1,4 @@
 import { ConeBaseGeometry } from './cone-base-geometry.js';
-import { calculateTangents } from './geometry-utils.js';
 
 /**
  * A procedural cone-shaped geometry.
@@ -68,7 +67,7 @@ class ConeGeometry extends ConeBaseGeometry {
         super(baseRadius, peakRadius, height, heightSegments, capSegments, false);
 
         if (opts.calculateTangents) {
-            this.tangents = calculateTangents(this.positions, this.normals, this.uvs, this.indices);
+            this.calculateTangents();
         }
     }
 }

src/scene/geometry/cylinder-geometry.js

@@ -1,5 +1,4 @@
 import { ConeBaseGeometry } from './cone-base-geometry.js';
-import { calculateTangents } from './geometry-utils.js';
 
 /**
  * A procedural cylinder-shaped geometry.
@@ -68,7 +67,7 @@ class CylinderGeometry extends ConeBaseGeometry {
         super(radius, radius, height, heightSegments, capSegments, false);
 
         if (opts.calculateTangents) {
-            this.tangents = calculateTangents(this.positions, this.normals, this.uvs, this.indices);
+            this.calculateTangents();
         }
     }
 }

src/scene/geometry/plane-geometry.js

@@ -1,5 +1,4 @@
 import { Vec2 } from '../../core/math/vec2.js';
-import { calculateTangents } from './geometry-utils.js';
 import { Geometry } from './geometry.js';
 
 /**
@@ -108,7 +107,7 @@ class PlaneGeometry extends Geometry {
         this.indices = indices;
 
         if (opts.calculateTangents) {
-            this.tangents = calculateTangents(positions, normals, uvs, indices);
+            this.calculateTangents();
         }
     }
 }

src/scene/geometry/sphere-geometry.js

@@ -1,4 +1,3 @@
-import { calculateTangents } from './geometry-utils.js';
 import { Geometry } from './geometry.js';
 
 /**
@@ -107,7 +106,7 @@ class SphereGeometry extends Geometry {
         this.indices = indices;
 
         if (opts.calculateTangents) {
-            this.tangents = calculateTangents(positions, normals, uvs, indices);
+            this.calculateTangents();
         }
     }
 }

src/scene/geometry/torus-geometry.js

@@ -1,5 +1,4 @@
 import { math } from '../../core/math/math.js';
-import { calculateTangents } from './geometry-utils.js';
 import { Geometry } from './geometry.js';
 
 /**
@@ -112,7 +111,7 @@ class TorusGeometry extends Geometry {
         this.indices = indices;
 
         if (opts.calculateTangents) {
-            this.tangents = calculateTangents(positions, normals, uvs, indices);
+            this.calculateTangents();
         }
     }
 }