Fix 'set:outline' event reporting the text color - #9260
Merged
Conversation
The outlineColor setter fired 'set:outline' with this._color instead of this._outlineColor. Fixes #9254. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Build size reportThis PR changes the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
outlineColorsetter firedset:outlinewiththis._color(the text color) instead ofthis._outlineColor, so listeners received the wrong value. One-line fix, mirroring whatset:colorfires.Fixes #9254
Verified: lint clean; unit suite at the
mainbaseline (2337 passing).Checklist
🤖 Generated with Claude Code