Skip to content

Add SceneDepthReader, reading a camera's scene depth back to the CPU #9274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvaligursky merged 14 commits into from
Sep 2, 2026
Merged

Add SceneDepthReader, reading a camera's scene depth back to the CPU #9274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
25292d1
Add SceneDepthReader, reading a camera's scene depth back to the CPU
Sep 1, 2026
c357660
updates
Sep 1, 2026
bf1944a
updates
Sep 1, 2026
3c8bf21
added half-float limit
Sep 1, 2026
d3554e5
updates
Sep 1, 2026
1bc2fe6
updates
Sep 1, 2026
cfa1f15
Merge remote-tracking branch 'origin/main' into mv-gsplat-scene-depth
Sep 2, 2026
867c1bc
Settle reads which no frame is going to service
Sep 2, 2026
cda75f0
Read back every encoding the scene depth arrives in
Sep 2, 2026
f1a0d2c
Release the quad the read pass renders with, and correct two descript…
Sep 2, 2026
6903801
Keep the splats in the scene depth on a half float device
Sep 2, 2026
64dbfc6
Give back the depth map request once, not twice
Sep 2, 2026
a672808
Read the region asked for, not the one mirrored about the view
Sep 2, 2026
346a365
Record the scene depth on the camera the scene level already has
Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 160 additions & 0 deletions examples/src/examples/gaussian-splatting/depth-effects.controls.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
import {
BindingTwoWay,
BooleanInput,
LabelGroup,
Panel,
SelectInput,
SliderInput
} from '@playcanvas/pcui/react';

/**
* @import { Observer } from '@playcanvas/observer'
* @import { ReactElement } from 'react'
*/

/**
* @param {{ observer: Observer }} props - The control panel props.
* @returns {ReactElement} The control panel.
*/
export function Controls({ observer }) {
return (
<>
<Panel headerText='Debug'>
<LabelGroup text='View'>
<SelectInput
type='string'
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.debug' }}
value={observer.get('settings.debug') || 'none'}
options={[
{ v: 'none', t: 'Composed frame' },
{ v: 'depth', t: 'Scene depth' },
{ v: 'scene', t: 'Scene color' },
{ v: 'dofcoc', t: 'DOF circle of confusion' },
{ v: 'dofblur', t: 'DOF blur' }
]}
/>
</LabelGroup>
</Panel>
<Panel headerText='Fog'>
<LabelGroup text='Enabled'>
<BooleanInput
type='toggle'
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.fog.enabled' }}
/>
</LabelGroup>
<LabelGroup text='Density'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.fog.density' }}
min={0}
max={0.1}
precision={3}
/>
</LabelGroup>
<LabelGroup text='Anisotropy'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.fog.anisotropy' }}
min={0}
max={0.95}
precision={2}
/>
</LabelGroup>
<LabelGroup text='Intensity'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.fog.intensity' }}
min={0}
max={5}
precision={2}
/>
</LabelGroup>
<LabelGroup text='Max distance'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.fog.maxDistance' }}
min={10}
max={100}
precision={0}
/>
</LabelGroup>
<LabelGroup text='Steps'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.fog.steps' }}
min={8}
max={64}
precision={0}
/>
</LabelGroup>
</Panel>
<Panel headerText='Depth of field'>
<LabelGroup text='Enabled'>
<BooleanInput
type='toggle'
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.dof.enabled' }}
/>
</LabelGroup>
<LabelGroup text='Focus size'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.dof.focusSize' }}
min={0.5}
max={10}
precision={1}
/>
</LabelGroup>
<LabelGroup text='Focus range'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.dof.focusRange' }}
min={0.5}
max={5}
precision={1}
/>
</LabelGroup>
<LabelGroup text='Blur radius'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.dof.blurRadius' }}
min={1}
max={10}
precision={1}
/>
</LabelGroup>
</Panel>
<Panel headerText='Sky'>
<LabelGroup text='Time'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.sky.time' }}
min={0}
max={24}
precision={1}
/>
</LabelGroup>
<LabelGroup text='Rotation'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.sky.rotation' }}
min={0}
max={360}
precision={0}
/>
</LabelGroup>
<LabelGroup text='Exposure'>
<SliderInput
binding={new BindingTwoWay()}
link={{ observer, path: 'settings.sky.exposure' }}
min={0}
max={2}
precision={2}
/>
</LabelGroup>
</Panel>
</>
);
}
Loading