refactor: replace default exports with named exports#731
Closed
dtychshenko wants to merge 3 commits intoplayer-ui:mainfrom
Closed
refactor: replace default exports with named exports#731dtychshenko wants to merge 3 commits intoplayer-ui:mainfrom
dtychshenko wants to merge 3 commits intoplayer-ui:mainfrom
Conversation
All default exports have been replaced with named exports across core packages, plugins, and React components. Closes player-ui#669 Affected packages: - `@player-ui/make-flow`: identify function - `@player-ui/partial-match-registry`: createObjectMatcher function - `@player-ui/player`: Logger classes and view plugins - `@player-ui/react`: ReactPlayer component and OnUpdatePlugin - `@player-ui/metrics-plugin`: MetricsCorePlugin class - `@player-ui/auto-scroll-manager-plugin-react`: scrollIntoViewWithOffset External dependencies have been verified to be not using the afffected default exports that changed.
All default exports have been replaced with named exports across core packages, plugins, and React components. Closes player-ui#669 Affected packages: - `@player-ui/make-flow`: identify function - `@player-ui/partial-match-registry`: createObjectMatcher function - `@player-ui/player`: Logger classes and view plugins - `@player-ui/react`: ReactPlayer component and OnUpdatePlugin - `@player-ui/metrics-plugin`: MetricsCorePlugin class - `@player-ui/auto-scroll-manager-plugin-react`: scrollIntoViewWithOffset External dependencies have been verified to be not using the afffected default exports that changed.
…er into fix/default-exports-669
Contributor
Author
|
Replacing with #732 with proper signed commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All default exports have been replaced with named exports across core packages, plugins, and React components. External dependencies have been verified to be not using the affected default exports that changed. Closes #669.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
All default exports have been replaced with named exports across core packages, plugins, and React components.
Affected packages:
@player-ui/make-flow: identify function@player-ui/partial-match-registry: createObjectMatcher function@player-ui/player: Logger classes and view plugins@player-ui/react: ReactPlayer component and OnUpdatePlugin@player-ui/metrics-plugin: MetricsCorePlugin class@player-ui/auto-scroll-manager-plugin-react: scrollIntoViewWithOffset