Skip to content

refactor: replace default exports with named exports#732

Merged
spentacular merged 2 commits intoplayer-ui:mainfrom
dtychshenko:refactor/default-exports-close-669
Oct 30, 2025
Merged

refactor: replace default exports with named exports#732
spentacular merged 2 commits intoplayer-ui:mainfrom
dtychshenko:refactor/default-exports-close-669

Conversation

@dtychshenko
Copy link
Copy Markdown
Contributor

All default exports have been replaced with named exports across core packages, plugins, and React components. External dependencies have been verified to be not using the affected default exports that changed. Closes #669.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Release Notes

All default exports have been replaced with named exports across core packages, plugins, and React components.

Affected packages:

  • @player-ui/make-flow: identify function
  • @player-ui/partial-match-registry: createObjectMatcher function
  • @player-ui/player: Logger classes and view plugins
  • @player-ui/react: ReactPlayer component and OnUpdatePlugin
  • @player-ui/metrics-plugin: MetricsCorePlugin class
  • @player-ui/auto-scroll-manager-plugin-react: scrollIntoViewWithOffset

All default exports have been replaced with named exports across core packages, plugins, and React components. Closes player-ui#669

Affected packages:
- `@player-ui/make-flow`: identify function
- `@player-ui/partial-match-registry`: createObjectMatcher function
- `@player-ui/player`: Logger classes and view plugins
- `@player-ui/react`: ReactPlayer component and OnUpdatePlugin
- `@player-ui/metrics-plugin`: MetricsCorePlugin class
- `@player-ui/auto-scroll-manager-plugin-react`: scrollIntoViewWithOffset

External dependencies have been verified to be not using the afffected default exports that changed.
@KetanReddy
Copy link
Copy Markdown
Member

@sugarmanz any reason these changes could cause a timeout on the android emulation stage?

@dtychshenko
Copy link
Copy Markdown
Contributor Author

@sugarmanz any reason these changes could cause a timeout on the android emulation stage?

I suspect it may have something to do with the android-test-fork job itself. I noticed that all the PRs that are being built and merged successfully are running from the main repo branches that execute android-test-trunk, while I don't have access to the main repo and using a forked repo.

@KetanReddy
Copy link
Copy Markdown
Member

@sugarmanz any reason these changes could cause a timeout on the android emulation stage?

I suspect it may have something to do with the android-test-fork job itself. I noticed that all the PRs that are being built and merged successfully are running from the main repo branches that execute android-test-trunk, while I don't have access to the main repo and using a forked repo.

Ah, that could be it. Forked jobs don't have access to our build cache so there might be some issue with testing if the the test is already cached where it is failing instead of returning false. Let me pull this branch into the repo and run it through CI from there.

@sugarmanz
Copy link
Copy Markdown
Member

@sugarmanz any reason these changes could cause a timeout on the android emulation stage?

It did time out due to no output, but that doesn't mean it wasn't building things behind the scenes. I guess I shouldn't have muted all the logs — was just trying to make it apparent that we were checking for cached results vs actually building/testing. I'll open up a PR to let Bazel log normally during the cache-check.

@KetanReddy
Copy link
Copy Markdown
Member

@sugarmanz any reason these changes could cause a timeout on the android emulation stage?

It did time out due to no output, but that doesn't mean it wasn't building things behind the scenes. I guess I shouldn't have muted all the logs — was just trying to make it apparent that we were checking for cached results vs actually building/testing. I'll open up a PR to let Bazel log normally during the cache-check.

Ah, I know circle will kill a job if it has no log output for 10m so if it was doing something it probably didn't show as such so it got killed.

@KetanReddy
Copy link
Copy Markdown
Member

I think the biggest question here @player-ui/reviewers is if this is going to be a major release? If so we probably need to stage this while we burn down the pre first major list.

Copy link
Copy Markdown
Member

@spentacular spentacular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding these and cleaning them up! LGTM.

@spentacular spentacular merged commit 3480d46 into player-ui:main Oct 30, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all default exports from Internal JS Player plugins

4 participants