refactor: replace default exports with named exports#732
refactor: replace default exports with named exports#732spentacular merged 2 commits intoplayer-ui:mainfrom
Conversation
All default exports have been replaced with named exports across core packages, plugins, and React components. Closes player-ui#669 Affected packages: - `@player-ui/make-flow`: identify function - `@player-ui/partial-match-registry`: createObjectMatcher function - `@player-ui/player`: Logger classes and view plugins - `@player-ui/react`: ReactPlayer component and OnUpdatePlugin - `@player-ui/metrics-plugin`: MetricsCorePlugin class - `@player-ui/auto-scroll-manager-plugin-react`: scrollIntoViewWithOffset External dependencies have been verified to be not using the afffected default exports that changed.
|
@sugarmanz any reason these changes could cause a timeout on the android emulation stage? |
I suspect it may have something to do with the |
Ah, that could be it. Forked jobs don't have access to our build cache so there might be some issue with testing if the the test is already cached where it is failing instead of returning false. Let me pull this branch into the repo and run it through CI from there. |
It did time out due to no output, but that doesn't mean it wasn't building things behind the scenes. I guess I shouldn't have muted all the logs — was just trying to make it apparent that we were checking for cached results vs actually building/testing. I'll open up a PR to let Bazel log normally during the cache-check. |
Ah, I know circle will kill a job if it has no log output for 10m so if it was doing something it probably didn't show as such so it got killed. |
|
I think the biggest question here @player-ui/reviewers is if this is going to be a major release? If so we probably need to stage this while we burn down the pre first major list. |
spentacular
left a comment
There was a problem hiding this comment.
Thanks for finding these and cleaning them up! LGTM.
All default exports have been replaced with named exports across core packages, plugins, and React components. External dependencies have been verified to be not using the affected default exports that changed. Closes #669.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
All default exports have been replaced with named exports across core packages, plugins, and React components.
Affected packages:
@player-ui/make-flow: identify function@player-ui/partial-match-registry: createObjectMatcher function@player-ui/player: Logger classes and view plugins@player-ui/react: ReactPlayer component and OnUpdatePlugin@player-ui/metrics-plugin: MetricsCorePlugin class@player-ui/auto-scroll-manager-plugin-react: scrollIntoViewWithOffset