Skip to content

Removed superfluous translation calls#123

Merged
adrianhurt merged 1 commit into
playframework:developfrom
mvdstam:develop
Jul 23, 2019
Merged

Removed superfluous translation calls#123
adrianhurt merged 1 commit into
playframework:developfrom
mvdstam:develop

Conversation

@mvdstam

@mvdstam mvdstam commented Jul 16, 2019

Copy link
Copy Markdown

Fixes #122

@mvdstam mvdstam mentioned this pull request Jul 16, 2019
Closed
@mkurz

mkurz commented Jul 16, 2019

Copy link
Copy Markdown
Member

Can you please fix the issue for the other versions as well?
See folders:

/play26-bootstrap3/
/play26-bootstrap4/
/play27-bootstrap3/

@mvdstam

mvdstam commented Jul 17, 2019

Copy link
Copy Markdown
Author

I've done the same in the other versions and rebased @mkurz.

Please check my changes first before you release this, as I'm not sure how to test this locally (see #122 (comment)). My IDE (IntelliJ IDEA) doesn't even seem to work properly with Twirl templates, so I'm flying blind here. 😄

Cheers!

@adrianhurt adrianhurt merged commit 9cda1af into playframework:develop Jul 23, 2019
@mvdstam mvdstam deleted the develop branch July 24, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvdstam @mkurz @adrianhurt