WIP change Try play page example from starter project to tutorials - #231
Merged
dwijnand merged 3 commits intoNov 27, 2018
Merged
Conversation
dwijnand
reviewed
Nov 27, 2018
| <li><a href="@controllers.documentation.ReverseRouter.latest(None, "Philosophy")">Our philosophy</a></li> | ||
| <li><a href="@controllers.documentation.ReverseRouter.latest(None, "Introduction")" target="_blank">Introduction to Play</a></li> | ||
| <li><a href="@controllers.documentation.ReverseRouter.latest(None, "Philosophy")" target="_blank">Our philosophy</a></li> | ||
| <li><a href="@controllers.documentation.ReverseRouter.latest(None, "Requirements")" target="_blank">Requirements for using Play</a></li> |
Contributor
Author
There was a problem hiding this comment.
Hi @dwijnand, Because if the reader wants to go read about Play and come back and try the examples, this way the page will still be open in their original tab. I've been doing a lot of documentation research lately and this is a common best practice when the link is supplemental information but the reader likely wants to come back and continue with the page.
Member
|
This went completely under my radar. Nice change @rstento |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dwijnand, @ignasi35, The objective of this is to change the recommended example (Follow the Hello World Tutorial) on the https://www.playframework.com/getting-started page to point to the correct Hello World Tutorial examples. In addition, I made some edits to simplify and clarify the page.
The changes I made look good when I build the web pages except, they do not display the links to download the Hello World Tutorials from Tech Hub:
No links appear here.
Maybe it needs to be live to pull in the links from the example-code-service? If not, could you take a look at the Application controller, I might have made a mistake while switching out the starters examples for tutorials. For your reference, on Tech Hub, the play-templates.conf file defines them like this: