Fix API search for Play1 - #424
Merged
Merged
Conversation
|
Hi @cies, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Contributor
Author
|
Done! |
mkurz
reviewed
Mar 23, 2021
| <form id="search" method="get" action="//www.google.com/search"> | ||
| <input type="search" name="q" placeholder="Search @version docs" results="10"> | ||
| <input type="hidden" name="sitesearch" value="@req.host@reverseRouter.home(context.alternateLang, version.name)"> | ||
| <input type="hidden" name="sitesearch" value="site:playframework.com@reverseRouter.home(context.alternateLang, version.name)"> |
Member
There was a problem hiding this comment.
@cies Please remove the site:, it gets added from google automatically. Actually having it breaks the google search.
Remove `site:` as per @mkurz remark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's broken now, and that's a pity as the docs are quite complete!