go_repo: rename third_party_path to deps_path - #379
Merged
chrisnovakovic merged 1 commit intoSep 2, 2026
Conversation
The purpose of `go_repo`'s `third_party_path` parameter isn't clear without a detailed reading of the please_go source code: it is the name of the package assumed to contain definitions of third-party Go module dependencies for the module whose targets are being generated. Rename the parameter to `deps_path` (while maintaining an alias for `third_party_path` for backwards compatibility) to make its purpose explicit.
toastwaffle
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of
go_repo'sthird_party_pathparameter isn't clear without a detailed reading of the please_go source code: it is the name of the package assumed to contain definitions of third-party Go module dependencies for the module whose targets are being generated. Rename the parameter todeps_path(while maintaining an alias forthird_party_pathfor backwards compatibility) to make its purpose explicit.