Fix Fedora manual-install CI failures by removing rev dependency from installer fallback#3450
Merged
Merged
Conversation
Owner
|
Hello, thanks for contributing for the first time! |
Agent-Logs-Url: https://github.com/plengauer/Thoth/sessions/a14c148e-7262-4528-aa7b-a68e800ee334 Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Fedora test failures due to missing packages
Fix Fedora manual-install CI failures by removing May 17, 2026
rev dependency from installer fallback
plengauer
requested changes
May 17, 2026
Agent-Logs-Url: https://github.com/plengauer/Thoth/sessions/94c894b5-08a8-4cda-ab85-b25b66773a45 Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/plengauer/Thoth/sessions/94c894b5-08a8-4cda-ab85-b25b66773a45 Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
plengauer
approved these changes
May 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the manual installer fallback path by removing the rev dependency from release-version extraction and adds focused regression coverage for the parsing behavior.
Changes:
- Adds
extract_release_versioninINSTALL.shusing POSIX shell parsing. - Replaces all fallback
rev | cut | revpipelines with the new helper. - Adds a unit test covering valid and invalid redirect header parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
INSTALL.sh |
Adds and uses a POSIX release-version extraction helper in package download fallbacks. |
tests/unit/test_unit_install_extract_release_version.sh |
Adds regression assertions for release redirect parsing behavior. |
moflwi
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fedora manual install job started failing across branches because
INSTALL.shfallback logic depended onrev, which is not guaranteed on minimal Fedora images. This caused release version parsing to fail and package download fallback to abort.Installer fallback parsing (cross-distro hardening)
rev | cut | revparsing inINSTALL.shfallback paths with a POSIX shellwhile readparser using parameter expansion.extract_release_versionhelper to parse redirectlocationlines./) so fallback behavior remains safe and predictable.Targeted regression coverage
tests/unit/test_unit_install_extract_release_version.sh> [!WARNING]
>
>