Skip to content

Fix Fedora manual-install CI failures by removing rev dependency from installer fallback#3450

Merged
plengauer merged 4 commits into
mainfrom
copilot/fix-fedora-test-failures
May 17, 2026
Merged

Fix Fedora manual-install CI failures by removing rev dependency from installer fallback#3450
plengauer merged 4 commits into
mainfrom
copilot/fix-fedora-test-failures

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026

The Fedora manual install job started failing across branches because INSTALL.sh fallback logic depended on rev, which is not guaranteed on minimal Fedora images. This caused release version parsing to fail and package download fallback to abort.

  • Installer fallback parsing (cross-distro hardening)

    • Replaced rev | cut | rev parsing in INSTALL.sh fallback paths with a POSIX shell while read parser using parameter expansion.
    • Added a dedicated extract_release_version helper to parse redirect location lines.
    • Added validation to ignore malformed extracted values (empty or containing /) so fallback behavior remains safe and predictable.
  • Targeted regression coverage

    • Added a focused unit test for fallback release-version extraction:
      • tests/unit/test_unit_install_extract_release_version.sh
    • Covers both a valid redirect line and an invalid path-like redirect value.
# before
... | grep location | tr -d '\r' | rev | cut -d / -f 1 | rev | cut -d v -f 2

# after
... | grep location | tr -d '\r' | extract_release_version

> [!WARNING]
>
>

@plengauer
Copy link
Copy Markdown
Owner

Hello, thanks for contributing for the first time!

Agent-Logs-Url: https://github.com/plengauer/Thoth/sessions/a14c148e-7262-4528-aa7b-a68e800ee334

Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Fedora test failures due to missing packages Fix Fedora manual-install CI failures by removing rev dependency from installer fallback May 17, 2026
Copilot AI requested a review from plengauer May 17, 2026 09:10
Copy link
Copy Markdown
Owner

@plengauer plengauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot see my comment

Comment thread INSTALL.sh Outdated
Copilot AI and others added 2 commits May 17, 2026 09:15
Agent-Logs-Url: https://github.com/plengauer/Thoth/sessions/94c894b5-08a8-4cda-ab85-b25b66773a45

Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/plengauer/Thoth/sessions/94c894b5-08a8-4cda-ab85-b25b66773a45

Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Copilot AI requested a review from plengauer May 17, 2026 09:19
@plengauer plengauer marked this pull request as ready for review May 17, 2026 09:20
@plengauer plengauer requested a review from moflwi as a code owner May 17, 2026 09:20
Copilot AI review requested due to automatic review settings May 17, 2026 09:20
@plengauer plengauer enabled auto-merge (squash) May 17, 2026 09:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the manual installer fallback path by removing the rev dependency from release-version extraction and adds focused regression coverage for the parsing behavior.

Changes:

  • Adds extract_release_version in INSTALL.sh using POSIX shell parsing.
  • Replaces all fallback rev | cut | rev pipelines with the new helper.
  • Adds a unit test covering valid and invalid redirect header parsing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
INSTALL.sh Adds and uses a POSIX release-version extraction helper in package download fallbacks.
tests/unit/test_unit_install_extract_release_version.sh Adds regression assertions for release redirect parsing behavior.

Comment thread tests/unit/test_unit_install_extract_release_version.sh
@plengauer plengauer merged commit bc5711c into main May 17, 2026
1545 of 1568 checks passed
@plengauer plengauer deleted the copilot/fix-fedora-test-failures branch May 17, 2026 13:36
plengauer added a commit that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test on fedora fails because of missing packages across all branches suddenly

4 participants