Fix Fedora manual-install CI failures by removing rev dependency from installer fallback (#3450)#3453
Merged
plengauer merged 1 commit intoMay 18, 2026
Conversation
…om installer fallback (#3450) Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the manual installer fallback path to avoid relying on rev (which can be missing on some distros like Fedora), improving resilience of the “download latest release” logic when the GitHub API path fails.
Changes:
- Add a POSIX-shell
extract_release_version()helper to parse the redirectlocation:header and extract the release tag version. - Replace the previous
rev | cut | revparsing in fallback download paths withextract_release_version. - Add a unit test covering version extraction behavior for valid vs invalid redirect URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
INSTALL.sh |
Replaces rev-based version parsing with extract_release_version() in the curl-verbose fallback download flow. |
tests/unit/test_unit_install_extract_release_version.sh |
Adds a unit test validating the release version extraction logic for redirect URLs. |
moflwi
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of commit bc5711c