Skip to content

Convert setup.py to pyproject.toml - #107

Merged
mauritsvanrees merged 2 commits into
masterfrom
convert-setup-py-to-pyproject-toml
Aug 12, 2026
Merged

Convert setup.py to pyproject.toml#107
mauritsvanrees merged 2 commits into
masterfrom
convert-setup-py-to-pyproject-toml

Conversation

@gforcada

@gforcada gforcada commented Mar 17, 2026

Copy link
Copy Markdown
Member

Use uvx --from plone.meta setup-to-pyproject to migrate setup.py configuration over to pyproject.toml leaving a single line on setup.py to keep it compatible with zc.buildout

@mister-roboto

Copy link
Copy Markdown

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada
gforcada force-pushed the convert-setup-py-to-pyproject-toml branch from ed2c297 to ccaa77e Compare March 18, 2026 10:43

@mauritsvanrees mauritsvanrees left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly fine, but I added some suggestions.

Comment thread pyproject.toml
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml
@gforcada
gforcada force-pushed the convert-setup-py-to-pyproject-toml branch from ccaa77e to a2f3758 Compare August 1, 2026 14:01
@gforcada
gforcada requested a review from mauritsvanrees August 1, 2026 14:01
@gforcada
gforcada force-pushed the convert-setup-py-to-pyproject-toml branch from a2f3758 to 3df9e86 Compare August 1, 2026 14:04
@gforcada

gforcada commented Aug 1, 2026

Copy link
Copy Markdown
Member Author

@mauritsvanrees I hope now is a good time to start the project to move metadata to pyproject.toml, Plone 6.2 is already out, we had already the first point release and things are stable enough to drive this.

As usual, I start with plone.batching 🙃

@mauritsvanrees mauritsvanrees left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines for the zcml autoinclude plugin are gone now. This was fixed in plone.meta meanwhile.

But: Products.CMFPlone explicitly loads the zcml of this package:

<include package="plone.batching" />

So I think this is totally fine. Probably for most plone.* packages this auto include plugin can be removed from setup.py/pyproject.toml. Well, those packages living below Products.CMFPlone anyway.

@mauritsvanrees
mauritsvanrees merged commit 393a12e into master Aug 12, 2026
10 of 14 checks passed
@mauritsvanrees
mauritsvanrees deleted the convert-setup-py-to-pyproject-toml branch August 12, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants