Convert setup.py to pyproject.toml - #107
Conversation
|
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
ed2c297 to
ccaa77e
Compare
mauritsvanrees
left a comment
There was a problem hiding this comment.
This is mostly fine, but I added some suggestions.
ccaa77e to
a2f3758
Compare
a2f3758 to
3df9e86
Compare
|
@mauritsvanrees I hope now is a good time to start the project to move metadata to As usual, I start with |
mauritsvanrees
left a comment
There was a problem hiding this comment.
The lines for the zcml autoinclude plugin are gone now. This was fixed in plone.meta meanwhile.
But: Products.CMFPlone explicitly loads the zcml of this package:
<include package="plone.batching" />
So I think this is totally fine. Probably for most plone.* packages this auto include plugin can be removed from setup.py/pyproject.toml. Well, those packages living below Products.CMFPlone anyway.
Use
uvx --from plone.meta setup-to-pyprojectto migratesetup.pyconfiguration over topyproject.tomlleaving a single line onsetup.pyto keep it compatible withzc.buildout