Improve folder_contents workflow state for images/files (show "inherited from parent" instead of just "no workflow state")

[tisto]

Is your feature request related to a problem? Please describe.

Editors are confused by the "no workflow set" message in the folder_contents view and don't know what to do with it.

Describe the solution you'd like

Ideally, we should show the actual de-factor workflow state which is inherited from the parent object:

This is a nice-to-have rather than a must-have feature.

[tisto]

@sneridagh @tiberiuichim opinions? thoughts?

[tiberiuichim]

@tisto maybe don't put anything there?

[tisto]

@tiberiuichim if we don't put anything there I'd guess the editor would still wonder what workflow status this object has.

[sneridagh]

We could easily infer parent's workflow, and use another visual indicator that it comes from parent (specially for the "More" -> "Display" menu), I guess. It would be more an aesthetic change than anything else.

[tisto]

Maybe we can start with a simple text implementation "Published (inherited by parent)" and then pass it to Albert for a more sophisticated solution.

[avoinea]

@sneridagh @tisto @tiberiuichim The problem is more deep than that. "No workflow state" is also displayed for custom workflow steps due this hard-coded messages: https://github.com/plone/volto/blob/master/src/components/manage/Contents/ContentsItem.jsx#L29

IMHO we should always take the review_state title from backend

[avoinea]

😞

[sneridagh]

This has an history behind, @albertcasado thought since long time ago that having both a "workflow action name" and a "workflow name" was confusing and wrong for a plain user. I agreed with him since day one. "Reject" and "Retract" are a good example. One never knows which is the destination state after that...

Since that "normalization" was never agreed on Plone itself, we decided to implemented it "hardcoded" in Volto. We could improve the current situation by making it configurable so "useSimpleWorkflowStates" settings config. I would also add a fallback to the Plone ones in case those are not set.

What do you think?

[avoinea]

@sneridagh Sounds good!

[tisto]

@sneridagh useSimpleWorkflowStates sounds like a good idea (and making this the default). I can still imagine use cases (or edge cases) where you might need to differentiate between workflow transition labels and states (because you have multiple different transitions to reach the same workflow state). Though, we should not over-complicate the Plone UI just because of some edge cases.