Added querystring search get option #4658
Conversation
✅ Deploy Preview for volto canceled.
|
robgietema
force-pushed
the
querystring-search-get
branch
from
da649a1
to
01e7433
Compare
|
This change should be properly documented. We faced not being able to use the |
Passing run #4831 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
The change is not enabled by default, so by default this will still use POST and not GET. You can opt-in to this behavior if you choose to do so. Discussion about this implementation can be found here: plone/plone.restapi#1252 |
|
@erral I agree that this should be properly documented. As @robgietema already mentioned, we are going to fully document this in plone.restapi at first. This should go into the Volto docs as well. Background: we are currently running a set of extensive load tests against a new Plone 6 / Volto 16 deployment of a high-profile website in Germany which will launch in April. Our analysis revealed that the querystring-search endpoint is responsible for a considerable amount of cache misses. Therefore we plan to switch from using POST to using GET for this installation. We will closely monitor if this approach has any downsides when we run into HTTP limits. Since most requests come from search/listing endpoints we do not expect to run into any limitations. Though, you never know. If that happens we might have to re-think our approach. Could you elaborate on what problems you exactly ran into? This might help us to plan our next steps... |
* master: (326 commits) Make URL a literal string to fix broken link (#4667) Move developer guidelines to contributing #4665 (#4666) Update Volto contributing to align with and refer to the new Plone co… (#4634) Release @plone/scripts 3.0.0 Changelog Added querystring search get option (#4658) Add current page parameter to the route in the listing and search block pagination (#4159) Fixed wrong localization on password reset page(#4656) (#4657) Release notes for 16.19.0 (#4655) Razzle upgrade notice in upgrade guide (#4641) Release generate-volto 7.0.0-alpha.3 Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640) 3092 improve spellcheck (#4633) developer process for first time contributing (#4617) Trigger CI on pull_request event (#4629) Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626) Set sameSite in `18N_LANGUAGE` cookie (#4627) Update simple-git (#4546) DefaultView (blocks disabled): Show field name as tip on hover of label (#4598) Fix regexp that checks valid URLs and improve tests (#4601) ...
No description provided.