Skip to content

fixed #6577 issue#6582

Closed
javatcoding1 wants to merge 1 commit intoplone:mainfrom
javatcoding1:main
Closed

fixed #6577 issue#6582
javatcoding1 wants to merge 1 commit intoplone:mainfrom
javatcoding1:main

Conversation

@javatcoding1
Copy link
Copy Markdown

  • [ok] I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • [ok ] I verified there aren't other open pull requests for the same change.
  • [ok ] I followed the guidelines in Contributing to Volto.
  • [ ok] I succesfully ran code linting checks on my changes locally.
  • [ ok] I succesfully ran unit tests on my changes locally.
  • [ ok] I succesfully ran acceptance tests on my changes locally.
  • [ ok] If needed, I added new tests for my changes.
  • [ok ] If needed, I added documentation for my changes, either in the Storybook or narrative documentation.
  • [ ok] I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Pull Request Description
This pull request addresses issue #6577, which involved incorrect Markdown implementation for heading levels. The following changes were made:

Updated the autoformatRules in volto/packages/volto-slate/src/editor/plugins/Markdown/constants.js to align with CommonMark specifications.
Modified the autoformat rule for a single # to generate an

tag, ## to generate

, and so on, ensuring consistency with Markdown standards.
Verified that these changes maintain compatibility with existing functionality and do not introduce regressions.

Closes #6577.

@mister-roboto
Copy link
Copy Markdown

javatcoding1 the email address in your commit does not match an email in your GitHub account. Thus it is impossible to determine whether you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have sent in your Plone Contributor Agreement, and received and accepted an invitation to join the Plone GitHub organization, then you might need to either add the email address on your Agreement to your GitHub account or change the email address in your commits. If you need to do the latter, then you should squash the commits with your matching email and push them.

Add more emails to your GitHub account:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

Change the email address in your commits:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 12, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 9093a62
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6784146af77a090008c600a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown heading does not correspond to right HTML Section Heading elements

2 participants