-
-
Notifications
You must be signed in to change notification settings - Fork 888
fix: aria-label for edit and drag block button #7424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/volto/src/components/manage/Blocks/Block/EditBlockWrapper.jsx
Outdated
Show resolved
Hide resolved
packages/volto/src/components/manage/Blocks/Block/EditBlockWrapper.jsx
Outdated
Show resolved
Hide resolved
packages/volto/src/components/manage/Blocks/Block/EditBlockWrapper.jsx
Outdated
Show resolved
Hide resolved
pnicolli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a conflict missing then I think this is good to go
davisagli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good improvement, just needs a couple adjustments.
|
@davisagli @pnicolli @sneridagh is it possibile to cherrypick this pr on 18.x.x? |
Caution
The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #5269
If your pull request includes changes to the documentation—either in narrative documentation, Storybook, or configuration—then a pull request preview will be generated and a link will populate in the description of your pull request below.
By clicking that link, you can use the visual diff menu in the upper right corner to navigate to pages that have changes, then display the diff by checking the
Show diffcheckbox.Needs cherrypick on 18