Enable volto-slate test suite via Vitest multi-project config#7903
Enable volto-slate test suite via Vitest multi-project config#7903davisagli merged 5 commits intoplone:mainfrom
Conversation
| `${projectRoot}/global-test-setup.js` | ||
| ], | ||
| globalSetup: `${projectRoot}/global-test-setup.js`, | ||
| coverage: { |
There was a problem hiding this comment.
It's best to have a coverage configuration per project.
davisagli
left a comment
There was a problem hiding this comment.
Maybe it should be obvious, but I'm not sure I understand the overall strategy here. Why did you add a multi-package configuration in packages/volto/vitest.config.mjs, instead of having separate configurations in packages/volto/vitest.config.mjs and packages/volto-slate/vitest.config.mjs?
|
@davisagli As we know many of the volto-slate dependencies come from Volto. If we create a separate configuration for volto-slate, there are a lot of dependency issues. I looked at both approaches, and maintaining a single configuration for Volto using Vitest multi-project configuration was the better choice. If the Volto team wants a separate configuration for volto-slate, I am also ready to do that. |
davisagli
left a comment
There was a problem hiding this comment.
@Abhishek-17h I'm ok with doing it this way if it's simpler. Thank you for taking care of it!
|
@davisagli I think this merge didn't work correctly. There are changes here that aren't in the main. For example, the modifications in https://github.com/plone/volto/pull/7903/changes#diff-69d75bb059d226e4c2cba44c6ab3b76e7f0dfebdcd3f45ed554ba292991ca7c8 |
ops I checked the wrong file. |
Closes #7892