Skip to content

Enable volto-slate test suite via Vitest multi-project config#7903

Merged
davisagli merged 5 commits intoplone:mainfrom
Abhishek-17h:fix/enable-volto-slate-tests-vitest
Mar 19, 2026
Merged

Enable volto-slate test suite via Vitest multi-project config#7903
davisagli merged 5 commits intoplone:mainfrom
Abhishek-17h:fix/enable-volto-slate-tests-vitest

Conversation

@Abhishek-17h
Copy link
Contributor

Closes #7892

`${projectRoot}/global-test-setup.js`
],
globalSetup: `${projectRoot}/global-test-setup.js`,
coverage: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to have a coverage configuration per project.

@Abhishek-17h Abhishek-17h requested a review from wesleybl March 8, 2026 05:11
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be obvious, but I'm not sure I understand the overall strategy here. Why did you add a multi-package configuration in packages/volto/vitest.config.mjs, instead of having separate configurations in packages/volto/vitest.config.mjs and packages/volto-slate/vitest.config.mjs?

@Abhishek-17h
Copy link
Contributor Author

Abhishek-17h commented Mar 19, 2026

@davisagli As we know many of the volto-slate dependencies come from Volto. If we create a separate configuration for volto-slate, there are a lot of dependency issues. I looked at both approaches, and maintaining a single configuration for Volto using Vitest multi-project configuration was the better choice. If the Volto team wants a separate configuration for volto-slate, I am also ready to do that.

@davisagli davisagli merged commit 4615892 into plone:main Mar 19, 2026
46 of 48 checks passed
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhishek-17h I'm ok with doing it this way if it's simpler. Thank you for taking care of it!

@wesleybl
Copy link
Member

wesleybl commented Mar 21, 2026

@davisagli I think this merge didn't work correctly. There are changes here that aren't in the main. For example, the modifications in https://github.com/plone/volto/pull/7903/changes#diff-69d75bb059d226e4c2cba44c6ab3b76e7f0dfebdcd3f45ed554ba292991ca7c8

@wesleybl
Copy link
Member

@davisagli I think this merge didn't work correctly. There are changes here that aren't in the main. For example, the modifications in https://github.com/plone/volto/pull/7903/changes#diff-69d75bb059d226e4c2cba44c6ab3b76e7f0dfebdcd3f45ed554ba292991ca7c8

ops I checked the wrong file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

volto-slate unit tests are not being executed

3 participants